RUST-1996 SCRAM-SHA-256 FIPS Compliance #1486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reason for closing: using a SHA256 HMAC with PBKDF2 is enough to ensure FIPS compliance, and the driver already does this. Figured its not worth adding a whole new dependency (which requires cmake and go installed) just to ensure FIPS certification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The prior implementation of PBKDF2 key derivation uses the
pbkdf2library which is just a pure Rust implementation.Changes
Switch to the
aws-lc-rsimplementation ofpbkdf2which can be configured to be FIPS-certified by enabling the "fips" feature: link